Zum Inhalt der Seite gehen

Image upload distortes portraits to landscapes

@Friendica Developers @Friendica Developers

Please see here:

Friendica Entwickler Marek

2022-12-27 19:45:22


Yet another photo test, should all be PORTRAIT!


Please click on any image to confirm that they are portraits


@Friendica Developers

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

utzer [Friendica]
utzer [Friendica]
• •
@Marek Bachmann @Friendica Entwickler Marek is it from an iPhone, I can remember that iPhones often have the wrong orientation of the photo, I had this a lot with photos my sister send me by Signal. She has an iPhone.
@Marek Bachmann @Friendica Entwickler Marek

Friendica Developers hat dies geteilt.

Als Antwort auf utzer [Friendica]

Marek Bachmann
Marek Bachmann
•
Thanks for bringing this up, but it is not from an IPhone.
I guess it is an issue in our backend introduced eventually between last stable a current develop since on the last stable the problem does not occur, cf.
https://fdc.mbbit.de/photos/marek/album/7363616c6554657374 (current dev) and
https://kassel.social/photos/marek/album/7363616c6554657374 (stable)

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

Marek Bachmann
Marek Bachmann
•
Please review my shared dev post directly
https://friendica-dev.mbbit.de/display/fa8fe840-1863-ab4b-5219-e24583154924

directly to see additional issue description.

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

Tio
Tio
• •
They are portraits for me when I click them. Desktop + Browser. My instance uses the Frio theme + some custom CSS on top that should not affect how these photos are displayed. idk if that's the sort of input you were looking for.

Friendica Developers hat dies geteilt.

Als Antwort auf Hypolite Petovan

Tio
Tio
• •
This is how they look for me:

They are squashed into a square shape. But when I click them they look proper:

Friendica Developers hat dies geteilt.

Als Antwort auf Tio

Marek Bachmann
Marek Bachmann
•
Thank you very much. As @Hypolite Petovan mentioned, it is high likely that something goes wrong with the small thumbnail generation.

What would also help me if this someone else / other instances face this issue.
Instances need to run on the latest dev branch, since in the current stable I do not face this issue neither.

So if someone on a dev instance might try to upload a portrait photo and tell me if the problem also occurs, I will create a new issue for this phenom on git.
@Hypolite Petovan

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

Marek Bachmann
Marek Bachmann
•
@Hypolite Petovan a general question which surely is in the scope of your expertise: Is there some method in git to check when a specific method / code block was last changed by a commit?
In this specific case, I would like to check when and what was changed in the Images::getScalingDimensions($width, $height, 90); method to confirm / rule out being the cause of this bug.
@Hypolite Petovan

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

Hypolite Petovan
Hypolite Petovan
• •
@Marek Bachmann Yes, it’s called git blame, although I’ve never used it in command line. In PHPStorm, it’s called “Annotate with git blame”.
@Marek Bachmann

Friendica Developers hat dies geteilt.

Als Antwort auf Hypolite Petovan

Marek Bachmann
Marek Bachmann
•
Wow, what a cool function. Tested it in PHPStorm. It really tells me for any line which commit changed this line.

Friendica Developers hat dies geteilt.

Als Antwort auf Hypolite Petovan

Marek Bachmann
Marek Bachmann
•
Just the name "blame" is a little rude :-D From this function's perspective, you are "to blame" for many code lines ;-)

Friendica Developers hat dies geteilt.

Als Antwort auf Marek Bachmann

Hypolite Petovan
Hypolite Petovan
• •
@Marek Bachmann It’s a common criticism of the name of the feature, several alternatives have been suggested but there’s little chance any of them will be adopted.
@Marek Bachmann

Friendica Developers hat dies geteilt.

⇧